Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): move low level utilities to @endo/common #1935

Merged
merged 4 commits into from
Jan 13, 2024

Conversation

erights
Copy link
Contributor

@erights erights commented Jan 8, 2024

closes: #XXXX
refs: #1815

Description

Successor to #1815 with utilities moved to a new @endo/utils package.

Note: I did not label this refactor(utils)!: ... because I intend to add reexports to keep compat before declaring this ready for review.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@erights erights self-assigned this Jan 8, 2024
@erights erights marked this pull request as draft January 8, 2024 23:52
@erights erights requested a review from kriskowal January 8, 2024 23:53
@erights erights force-pushed the markm-meta-ops-migrate branch from dfa033f to 1cca5d8 Compare January 9, 2024 00:24
@kriskowal
Copy link
Member

I want this to be called @endo/score as a pun on underscore.

To allow manual minimization of the weight of a program’s dependency graph, each utility function should be separately importable, like @endo/score/list-difference.js.

packages/utils/CHANGELOG.md Outdated Show resolved Hide resolved
packages/utils/README.md Outdated Show resolved Hide resolved
packages/utils/package.json Outdated Show resolved Hide resolved
packages/utils/test/test-index.js Outdated Show resolved Hide resolved
@erights erights force-pushed the markm-meta-ops-migrate branch from 5d182ad to 9da1b4e Compare January 9, 2024 05:46
@erights erights force-pushed the markm-meta-ops-migrate branch 2 times, most recently from 314feb0 to 9c5c70c Compare January 11, 2024 01:24
@erights
Copy link
Contributor Author

erights commented Jan 11, 2024

I want this to be called @endo/score as a pun on underscore.

No single entendre puns. I'll allow it if you also have some rationalization, however bizarre or awkward, why "score" is a sensible name for this package. ;)

@erights erights force-pushed the markm-meta-ops-migrate branch from 9c5c70c to d3638f7 Compare January 11, 2024 06:28
@kriskowal
Copy link
Member

I want this to be called @endo/score as a pun on underscore.

No single entendre puns. I'll allow it if you also have some rationalization, however bizarre or awkward, why "score" is a sensible name for this package. ;)

I can only appeal to the tradition of:

However, I cannot think of a winning pun on “score” that cuts it, which is a strike that really underlines your point. Scratch that.

@erights
Copy link
Contributor Author

erights commented Jan 11, 2024

However, I cannot think of a winning pun on “score” that cuts it, which is a strike that really underlines your point. Scratch that.

I asked for a double entendre and got a meta entendre. Serves me right ;)

@erights erights force-pushed the markm-meta-ops-migrate branch from d3638f7 to efe9cb5 Compare January 13, 2024 02:02
@erights
Copy link
Contributor Author

erights commented Jan 13, 2024

On a slack channel, we settled on a package name of common

@erights erights force-pushed the markm-meta-ops-migrate branch from 0eef830 to 2184222 Compare January 13, 2024 02:51
@erights erights changed the title refactor(utils): move low level utilities to @endo/utils refactor(utils): move low level utilities to @endo/common Jan 13, 2024
@erights erights force-pushed the markm-meta-ops-migrate branch from 2184222 to 26f5236 Compare January 13, 2024 02:56
@erights erights changed the title refactor(utils): move low level utilities to @endo/common refactor(common): move low level utilities to @endo/common Jan 13, 2024
@erights erights force-pushed the markm-meta-ops-migrate branch from c9f3247 to 748249e Compare January 13, 2024 04:45
packages/common/index.js Show resolved Hide resolved
packages/common/package.json Show resolved Hide resolved
packages/common/src/ident-checker.js Outdated Show resolved Hide resolved
@erights erights marked this pull request as ready for review January 13, 2024 05:42
@erights erights enabled auto-merge (squash) January 13, 2024 05:43
@erights erights merged commit 3de87dd into master Jan 13, 2024
14 checks passed
@erights erights deleted the markm-meta-ops-migrate branch January 13, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants