feat(compartment-mapper): Archive source URL suffixes #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves stack traces from archived applications, by including a source URL suffix suitable to match a file in an IDE workspace with a reasonable confidence in its uniqueness, but no guarantee. This requires threading the original package name, since the last path component is likely to match to the parent directory.
Using the last path component is necessary since, for example, the package named
@endo/compartment-mapperlies atpackages/compartment-mapperin its workspace and packages generally do not stutter their org in a workspace repository.There are notable exceptions to the necessary heuristic. Agoric SDK's SwingSet directory contains a package named swingset-vat.
Fixes Agoric/agoric-sdk#3899