Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need source-prefix-based stackframe filter #488

Open
erights opened this issue Oct 12, 2020 · 3 comments
Open

Need source-prefix-based stackframe filter #488

erights opened this issue Oct 12, 2020 · 3 comments
Assignees
Labels
debugging support kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024

Comments

@erights
Copy link
Contributor

erights commented Oct 12, 2020

#447 give us a start on conveniences needed for treating compartments as filtering "topics" for console output. We expect the dominant use of compartments to be a compartment per package, where a package is identified with a specifier string corresponding to a source location. As of #447 our stacks have lots of infrastructure frames in them, creating visual noise and making it hard to find the frames of actual interest. It would be nice for the default conveniences for these two forms of filtering to be coordinated, so that it is each to filter out a package's code both from console calls originating from that package and the stack frames of code in that package.

@erights
Copy link
Contributor Author

erights commented Oct 12, 2020

Our current Error taming provides a getStackString which #447 uses to render unfiltered stacks.
This issue requires the Error taming to also support the proposed getStack, so that we can accurately filter rather than scraping text.

@erights
Copy link
Contributor Author

erights commented Oct 12, 2020

Causeway filtered stacks by source prefix to good effect. In the graph visualizations, it would first collapse out turns for which no frames survived that filter. Those turns are pure infrastructure, for example from an asynchronous programming abstraction like a promise combinator.

@erights
Copy link
Contributor Author

erights commented Feb 19, 2021

We took a big first step towards this with the stackFiltering option. But it (as well as several other options) also need to accept configuration data.

See #578

@kriskowal kriskowal added the kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugging support kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Projects
None yet
Development

No branches or pull requests

2 participants