We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
after a typeof x === 'string' test, the type of x is refined to string. But we don't get the same benefit from mustMatch(x, M.string()).
typeof x === 'string'
x
string
mustMatch(x, M.string())
migrate from @agoric/internal. In particular, in @agoric/internal's typeCheck.test.js:
@agoric/internal
typeCheck.test.js
const Mstring = /** @type {TypedPattern<string>} */ (M.string()); const unknownString = /** @type {unknown} */ (''); test('mustMatch', t => { // @ts-expect-error unknown type unknownString.length; mustMatch(unknownString, Mstring); unknownString.length; t.pass(); });
TypedPattern<T> can make claims that are stronger than the pattern actually enforces.
TypedPattern<T>
none
port tests from agoric-sdk
none that I can think of
cc @turadg @erights
The text was updated successfully, but these errors were encountered:
Thanks for filing. Here's the TODO line in agoric-sdk: https://github.com/Agoric/agoric-sdk/blob/1cb791553d0d27df9953304e556652c216988909/packages/store/src/index.js#L63-L67
Of course meanwhile it's fine to import mustMatch from @agoric/internal or @agoric/store.
mustMatch
@agoric/store
Sorry, something went wrong.
No branches or pull requests
What is the Problem Being Solved?
after a
typeof x === 'string'
test, the type ofx
is refined tostring
.But we don't get the same benefit from
mustMatch(x, M.string())
.Description of the Design
migrate from
@agoric/internal
. In particular, in@agoric/internal
'stypeCheck.test.js
:Security Considerations
TypedPattern<T>
can make claims that are stronger than the pattern actually enforces.Scaling Considerations
none
Test Plan
port tests from agoric-sdk
Compatibility / Upgrade Considerations
none that I can think of
cc @turadg @erights
The text was updated successfully, but these errors were encountered: