Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sortByRank misplaces undefined values for reversed comparison functions #2594

Closed
gibson042 opened this issue Oct 19, 2024 · 1 comment · Fixed by #2597
Closed

sortByRank misplaces undefined values for reversed comparison functions #2594

gibson042 opened this issue Oct 19, 2024 · 1 comment · Fixed by #2597
Labels
bug Something isn't working

Comments

@gibson042
Copy link
Contributor

(reflects Agoric/agoric-sdk#4260 )

sortByRank currently uses Array.prototype.sort directly, and so only works correctly when given a compare function that considers undefined strictly bigger (>) than everything else. This is because Array.prototype.sort bizarrely moves all undefineds to the end of the array regardless, without consulting the compare function. This is a genuine bug for us NOW because sometimes we sort in reverse order by passing a reversed rank comparison function.

See Agoric/agoric-sdk#4252 , which fixed the forward rank comparison so that sortByRank applied to it would be consistent. The remaining live problem is only where we use the reversed comparison.
@gibson042 gibson042 added the bug Something isn't working label Oct 19, 2024
gibson042 added a commit that referenced this issue Oct 21, 2024
@gibson042
fix(marshal): Reverse-sort undefined values into the right place
6eaddee 
Fixes #2594
gibson042 added a commit that referenced this issue Oct 21, 2024
@gibson042
fix(marshal): Reverse-sort undefined values into the right place
67f7e0d 
Fixes #2594
gibson042 added a commit that referenced this issue Oct 21, 2024
@gibson042
fix(marshal): Reverse-sort undefined values into the right place
5a06beb 
Fixes #2594
gibson042 added a commit that referenced this issue Oct 22, 2024
@gibson042
fix(marshal): Reverse-sort undefined values into the right place
9a7b0dd 
Fixes #2594
gibson042 added a commit that referenced this issue Oct 22, 2024
@gibson042
fix(marshal): Reverse-sort undefined values into the right place
ad085ad 
Fixes #2594
@gibson042
Copy link
Contributor Author

Fixed by #2597

@gibson042 gibson042 mentioned this issue Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(marshal)!: Update compareRank to terminate comparability at the first remotable endojs/endo
1 participant
@gibson042