Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair types following extraction of @endo/pass-style from @endo/marshal #1446

Closed
erights opened this issue Jan 14, 2023 · 6 comments
Closed
Assignees
Labels
kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024

Comments

@erights
Copy link
Contributor

erights commented Jan 14, 2023

#1439 is the PR that extracts passStyleOf and friends from @endo/marshal into the newly created @endo/pass-style . However, after getting everything but linting working, I then had to add bf9fa86 only to suppress the resulting type errors and import-order complaints.

I just blindly suppressed them because I could not figure out how to repair them properly. This issue is the reminder that these still need to be repaired.

See #1439 (review)

@erights
Copy link
Contributor Author

erights commented Jan 14, 2023

@turadg , ok if I give this to you?

@kriskowal kriskowal added the kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 label Jan 8, 2024
@kriskowal
Copy link
Member

What’s the status of this?

@turadg
Copy link
Member

turadg commented Jan 8, 2024

Not yet prioritized

@erights
Copy link
Contributor Author

erights commented Mar 4, 2024

@turadg , would this be fixed by your recent Passable-typing PR?

@turadg
Copy link
Member

turadg commented Mar 4, 2024

@erights i expect so

@turadg
Copy link
Member

turadg commented May 6, 2024

Looks like this was done at some point

@turadg turadg closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Projects
None yet
Development

No branches or pull requests

3 participants