fix: retire deprecated "@@asyncIterator" sending only #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We first had a special marshal encoding special case for
Symbol.asyncIterator. Over 4 months ago we introduced general symbol handling. But we kept sending the special case in case there were non-updated receivers, and kept understanding the special case on reception in case there were non-updated senders.These four months is enough to give us confidence that there are no longer only receivers that do not understand the new symbol encoding. So this PR retires the code for sending the special case. Once we're confident that there are no senders older than this PR we'll be able to update the receivers too.