fix(compartment-mapper): Needless genericity considered harmful #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The has utility function in the compartment mapper did not need to be generic. Because it was generic, at a vast distance down the dependency chain, TypeScript proposed bizarre combinations of types for each of the uses, probably sampling the first ambient type that emitted a valid function, then failed type check in compartment-mapper.
mhofman
approved these changes
Jan 28, 2022
| @@ -45,10 +45,8 @@ const defaultCompartment = Compartment; | |||
| const q = JSON.stringify; | |||
|
|
|||
| /** | |||
| * @template {string | number} Key | |||
| * @template Value | |||
There was a problem hiding this comment.
There laid your problem!
It should have been @template {any} Value
Value is a deprecated alias for AmountValue.
You should be able to keep it generic if you want.
There was a problem hiding this comment.
After double checking, adding a type constraint wouldn't have helped, only renaming to something that didn't conflict with a type in scope would have, e.g. TValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The has utility function in the compartment mapper did not need to be generic. Because it was generic, at a vast distance down the dependency chain, TypeScript proposed bizarre combinations of types for each of the uses, probably sampling the first ambient type that emitted a valid function, then failed type check in compartment-mapper.