Retore edits from agoric-sdk #4304 #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
4312-markm-restore-edits-from-agoric-sdk
branch
from
06359d0 to
1789233
Compare
kriskowal
approved these changes
Jan 24, 2022
erights
force-pushed
the
4312-markm-restore-edits-from-agoric-sdk
branch
from
1789233 to
f79cf7c
Compare
erights
force-pushed
the
4312-markm-restore-edits-from-agoric-sdk
branch
from
f79cf7c to
e1b4466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore edits from Agoric/agoric-sdk#4304 to the marshal package.
Fixes Agoric/agoric-sdk#4312 again ;)
Have recognition of passable Error obtain name from prototype, skipping any own name property on the error instance.
Note several of the places we need to revisit when we admit error.cause and error.errors.
Inline TODOs reminding us to revisit issues identified by zestival