Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Current code generates twice more benign labels than needed #4

Open
asafnadler opened this issue May 13, 2018 · 2 comments
Open

Comments

@asafnadler
Copy link

The function gen_data takes the count of malicious+benign domains and adds this number of labels to the malicious labels.

@rastafrange
Copy link

@asafnadler I've just checked and it seems to work okay for me. I have labels correctly assigned. Do you have not correct labels for malicious domain?

@KuangHao95
Copy link

In data.py:
domains += get_alexa(len(domains))
labels += ['benign']*len(domains)
change to:
pre_len = len(domains)
domains += get_alexa(len(domains))
labels += ['benign']*pre_len

Use previous domain list length to generate labels with same length, or just divide latter length by 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants