Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ProxyLimits naming in favour of max_connections and max_keepalive #948

Closed
yeraydiazdiaz opened this issue May 13, 2020 · 0 comments · Fixed by #968
Closed

Deprecate ProxyLimits naming in favour of max_connections and max_keepalive #948

yeraydiazdiaz opened this issue May 13, 2020 · 0 comments · Fixed by #968
Labels
user-experience Ensuring that users have a good experience using the library
Milestone
v0.13

Comments

@yeraydiazdiaz
Copy link
Contributor

Prompted by #942 (comment)

The PoolLimits class uses soft_limit and hard_limit whereas in httpcore we use max_connections and max_keepalive which are clearer.
@yeraydiazdiaz yeraydiazdiaz added this to the v1.0 milestone May 13, 2020
@florimondmanca florimondmanca added the user-experience Ensuring that users have a good experience using the library label May 15, 2020
@tomchristie tomchristie mentioned this issue May 20, 2020
Closed
@yeraydiazdiaz yeraydiazdiaz modified the milestones: v1.0, v0.13 May 21, 2020
@tomchristie tomchristie mentioned this issue May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
user-experience Ensuring that users have a good experience using the library
Projects
None yet
Milestone
v0.13
Development

Successfully merging a pull request may close this issue.

Rename pool limit options encode/httpx
2 participants
@yeraydiazdiaz @florimondmanca