Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the type of Extensions from Mapping to MutableMapping. #2803

Merged
merged 9 commits into from
Sep 11, 2023
Merged

Change the type of Extensions from Mapping to MutableMapping. #2803

merged 9 commits into from
Sep 11, 2023
+5 −3

Conversation

karpetrosyan
Copy link
Member

Closes #2794

@karpetrosyan karpetrosyan marked this pull request as draft August 1, 2023 12:49
@karpetrosyan
Copy link
Member Author

We need httpcore release to resolve this type error.

@tomchristie
Copy link
Member

We need httpcore release to resolve this type error.

Okay, shall we add httpcore @ git+https://github.com/encode/httpcore@master to the requirements.txt in this PR to demo that this'd resolve the type issues.

trim21
trim21 reviewed Aug 7, 2023
View reviewed changes
pyproject.toml Show resolved Hide resolved
@karpetrosyan karpetrosyan marked this pull request as ready for review August 7, 2023 14:04
@karpetrosyan karpetrosyan marked this pull request as draft August 7, 2023 14:09
@trim21
Copy link
Contributor

trim21 commented Sep 8, 2023

looks like we can continue on this issue？

@karpetrosyan karpetrosyan marked this pull request as ready for review September 8, 2023 19:02
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Sep 11, 2023
@sunpoet
www/py-httpx: Allow build with py-httpcore 0.18.0+
e547a4c 
- Bump PORTREVISION for package change

Obtained from:	encode/httpx#2803
@karpetrosyan karpetrosyan merged commit adbcd0e into encode:master Sep 11, 2023
4 checks passed
@karpetrosyan karpetrosyan deleted the change-response-extensions-type branch September 11, 2023 06:29
@trim21 trim21 mentioned this pull request Sep 11, 2023
Merged
@tomchristie tomchristie changed the title Change extensions type Change the type of Extensions from Mapping to MutableMapping. Sep 11, 2023
@karpetrosyan karpetrosyan mentioned this pull request Nov 14, 2023
Merged
3 tasks
@zevisert zevisert mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trim21 trim21 trim21 left review comments

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the type of Extensions from Mapping to MutableMapping.
4 participants
@karpetrosyan @tomchristie @trim21 @zanieb