Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and add test for SearchFilter m2m behavior #7351

Closed
3 tasks
Pomax opened this issue May 27, 2020 · 4 comments
Closed
3 tasks

Document and add test for SearchFilter m2m behavior #7351

Pomax opened this issue May 27, 2020 · 4 comments
Labels

Comments

@Pomax
Copy link

Pomax commented May 27, 2020

Refiled as issue from PR #7094

"A change to rest_framework's filters.py, introduced in #5264 and pushed out as part of v3.6.4, appears to have changed how searching with multiple filter conditions works when the fields involved are ManyToMany relations rather than plain model fields or ForeignKey relations."

This PR got closed but then reopened to track outstanding work, which should really be an issue, so as per @rpkilby notes:

  • v3.6.4 Release notes need to more clearly point out the breaking change
  • Expected m2m behavior should have a test (see closed PR)
  • We might also want to add that vague note pointing users to Django's to-many queries docs.
@auvipy auvipy added this to the 3.15 milestone Feb 7, 2023
@auvipy auvipy removed this from the 3.15 milestone Jul 11, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@auvipy auvipy removed the stale label Sep 21, 2023
@auvipy
Copy link
Member

auvipy commented Sep 21, 2023

would be great if you can revisit the issue.

@Pomax
Copy link
Author

Pomax commented Sep 21, 2023

Having changed jobs years ago to a job that doesn't even involve Python, this is unlikely to happen. Not to mention that the original PR got ignored into oblivion, so clearly no one on the DRF team cared for over two years. Feel free to pick up the ball and run with it, but I won't be revisiting it ;)

@auvipy
Copy link
Member

auvipy commented Oct 3, 2023

I'm new in the team. thanks for your old efforts. we will pass this to others.

@tomchristie tomchristie closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants