Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlize_quoted_links filter is not registered correctly #6201

Closed
dkliban opened this issue Sep 21, 2018 · 2 comments
Closed

urlize_quoted_links filter is not registered correctly #6201

dkliban opened this issue Sep 21, 2018 · 2 comments

Comments

@dkliban
Copy link
Contributor

dkliban commented Sep 21, 2018

Steps to reproduce

Put the following in a template:

{% autoescape off %}{% for key, val in response_headers|items %}
<b>{{ key }}:</b> <span class="lit">{{ val|break_long_headers|urlize_quoted_links|my_filter }}</span>{% endfor %}

</span>{{ content|urlize_quoted_links|my_filter }}</pre>{% endautoescape %}
</div>

Expected behavior

my_filter receives unescaped input text

Actual behavior

my_filter receives escaped text

I've put together a PR for this issue. #6191

@dkliban
Copy link
Contributor Author

dkliban commented Sep 27, 2018

@tomchristie Please take a look at this issue. I made the PR based on the documentation from django[0].

[0] https://docs.djangoproject.com/en/2.1/howto/custom-template-tags/#filters-and-auto-escaping

@rpkilby rpkilby modified the milestone: 3.9 Release Sep 30, 2018
@rpkilby
Copy link
Member

rpkilby commented Dec 3, 2018

Somehow this was detached from the milestone.. either way. PR was added, so not an issue.

@rpkilby rpkilby closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants