Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track ongoing deprecation #3372

Closed
xordoquy opened this issue Sep 8, 2015 · 6 comments
Closed

Track ongoing deprecation #3372

xordoquy opened this issue Sep 8, 2015 · 6 comments
Assignees
Labels

Comments

@xordoquy
Copy link
Collaborator

xordoquy commented Sep 8, 2015

While we have a deprecation policy, we don't track the ongoing deprecations.
We need to have something similar to https://docs.djangoproject.com/en/1.8/internals/deprecation/ to help us conform to the policy.

@auvipy
Copy link
Member

auvipy commented Sep 9, 2015

+1

@carltongibson
Copy link
Collaborator

Do you think it's worth having a wrapper function that takes a version and a message...

 deprecated((3,1,3), "Moved to ... Use ... instead")

or such.

Inside we could check against the current version. Raise the appropriate warning. Assert False if too many versions have gone by.

If we used this everywhere we'd never miss any deprecations. We could also search for it to find all instances.

@xordoquy
Copy link
Collaborator Author

xordoquy commented Sep 9, 2015

@carltongibson Really interesting.

@tomchristie
Copy link
Member

Neat idea yeah.

@carltongibson
Copy link
Collaborator

OK. I'll draft something up.

(Put this in compat.py?)

@tomchristie
Copy link
Member

Closing as per #3404. Don't see this as a priority, hasn't been a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants