Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LimitOffsetPagination raises Type error if PAGE_SIZE not set #2667

Closed
balsdorf opened this issue Mar 10, 2015 · 0 comments · Fixed by #2700
Closed

LimitOffsetPagination raises Type error if PAGE_SIZE not set #2667

balsdorf opened this issue Mar 10, 2015 · 0 comments · Fixed by #2700
Labels
Milestone

Comments

@balsdorf
Copy link
Contributor

In 3.1.0 if you do not have PAGE_SIZE set you get a TypeError: unsupported operand type(s) for +: 'int' and 'NoneType'.

I believe a friendlier message would be useful in this case. I was going to submit a patch but was not sure exactly how you would like to handle this.

Exception Type: TypeError
Exception Value:
unsupported operand type(s) for +: 'int' and 'NoneType'
Exception Location: /work/virtual/skysql_upgrade/local/lib/python2.7/site-packages/rest_framework/pagination.py in paginate_queryset, line 396

@tomchristie tomchristie modified the milestone: 3.1.1 Release Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants