Raise error when attempting to save serializer if data is not valid.

[j0hnsmith]

I'm seeing some unexpected behaviour in v3

In [23]: MyModel.objects.count()
Out[23]: 0

In [24]: s = MyModelSerializer(data={'foo': 'bar'})

In [25]: s.is_valid()
Out[25]: False

In [26]: s.errors
Out[26]: ReturnDict([('baz', [u'This field is required.'])])

In [27]: s.save()
Out[27]: <MyModel: MyModel object>

In [28]: MyModel.objects.count()
Out[28]: 1

Not necessarily a problem but perhaps worth a note in the docs.

[j0hnsmith]

I just found s.is_valid(raise_exception=True)

[tomchristie]

Retitled slightly.

[phalt]

Should the default on this be def is_valid(self, raise_exception=True): ?

What's the rational for having raise_exception=False as the default?

[tomchristie]

Should the default on this be is_valid(self, raise_exception=True)

I could go either way, but somehow it feels like having it raise the exception should be the explicit case.

This ticket for ".save() should raise an error if the data was not validated" still stands on it's own of course.