Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-sass #4

Open
ixax opened this issue Aug 5, 2015 · 9 comments
Open

Upgrade node-sass #4

ixax opened this issue Aug 5, 2015 · 9 comments

Comments

@ixax
Copy link
Contributor

ixax commented Aug 5, 2015

Requested features: https://github.com/google/material-design-lite/blob/master/src/button/_button.scss#L17 (actually the file is here: https://github.com/google/material-design-lite/blob/master/src/_variables.scss)

@DimitryDushkin
Copy link
Contributor

+1

3 similar comments
@tadatuta
Copy link
Member

tadatuta commented Aug 6, 2015

👍

@dab
Copy link

dab commented Aug 6, 2015

👍

@sipayRT
Copy link

sipayRT commented Aug 7, 2015

👍

@ixax
Copy link
Contributor Author

ixax commented Aug 7, 2015

Got it! At this weekend will try to build and upload a release 💣

@DimitryDushkin
Copy link
Contributor

It also can be closed

@ixax
Copy link
Contributor Author

ixax commented Aug 13, 2015

No, it can't.
@tadatuta try this branch https://github.com/enb-make/enb-sass/tree/imports

@tadatuta
Copy link
Member

There are still some problems in imports branch :(

@veged got a case with broken import resolving and as a result this loop never ended (and error was never caught and logged).

Will try to find some time to provide minimal test case.

@veged
Copy link

veged commented Aug 17, 2015

I suggest to change here fadbe64#diff-09f26496655e6744ced8766d49bdb26bL72 while (!filename && i > 0) {

but there are still cases when var searchString = ': begin */' may be not found in all content, so later fadbe64#diff-09f26496655e6744ced8766d49bdb26bL81 filename[1] cause exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants