Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ignoreComments: false to htmlDiffer #54

Closed
qfox opened this issue Feb 12, 2015 · 5 comments · Fixed by #72
Closed

Pass ignoreComments: false to htmlDiffer #54

qfox opened this issue Feb 12, 2015 · 5 comments · Fixed by #72

Comments

@qfox
Copy link
Contributor

qfox commented Feb 12, 2015

We should disable this option (enabled by default) because it's a kind of #define true false;.
And for those who need it we can make possible to revert it via option passed to tmpl-specs in .enb/make.js.

@blond
Copy link
Member

blond commented Feb 21, 2015

Should we add an htmlDiffer option which will override bem preset?

examples.configure({
    destPath: 'desktop.tmpl-specs',
    levels: ['blocks'],
    htmlDiffer: {
        ignoreComments: false
    },
    /* ... */
});

@qfox
Copy link
Contributor Author

qfox commented Feb 21, 2015

I'd say yes. ignoreComments shouldn't be enabled by default imho.

@eGavr
Copy link
Contributor

eGavr commented Feb 21, 2015

Using this format as @andrewblond proposed, we'll be able to redefine any option we want ;)

@blond
Copy link
Member

blond commented Feb 21, 2015

Added doc for htmlDiffer option: f983f60

@blond
Copy link
Member

blond commented Feb 21, 2015

Release v0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants