Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps tech builds wrong boolean mods #113

Closed
tadatuta opened this issue Mar 18, 2015 · 0 comments · Fixed by #134
Closed

deps tech builds wrong boolean mods #113

tadatuta opened this issue Mar 18, 2015 · 0 comments · Fixed by #134
Assignees
Labels
Milestone

Comments

@tadatuta
Copy link
Member

In block's deps:

{
    shouldDeps : {
        mods : ['disabled', 'focused']
    }
}

results in

    // ...
    {
        "block": "textarea",
        "mod": "0"
    },
    {
        "block": "textarea",
        "mod": "1"
    },
    // ...
    {
        "block": "textarea",
        "mod": "0",
        "val": "disabled"
    },
    {
        "block": "textarea",
        "mod": "1",
        "val": "focused"
    }
    // ...

in bundle deps file.

Tested on project-stub with just ({ block : 'textarea' }) in index.bemjson.js.
Same bemjson results in proper bundle deps when built with deps-old.

@tadatuta tadatuta added the bug label Mar 18, 2015
@blond blond added this to the 1.0.5 milestone Apr 21, 2015
@blond blond self-assigned this Apr 21, 2015
@blond blond modified the milestones: 1.0.5, 2.0 Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants