Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

findings V 1.2.3 #29

Closed
SpaceTeddy opened this issue Jan 3, 2019 · 5 comments
Closed

findings V 1.2.3 #29

SpaceTeddy opened this issue Jan 3, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@SpaceTeddy
Copy link
Contributor

SpaceTeddy commented Jan 3, 2019

only related to ES73 aka RC35 compatible types:

  • night/day/auto mode -> offset is 7 .... 6 should be Room-offset setting -> verified with my boiler
    #define EMS_OFFSET_RC35Set_mode 7 // position of thermostat mode

  • void _process_RC35StatusMessage(uint8_t * data, uint8_t length) , we have to read the Thermostat current_temp from here (0x3E) as well! Offset is 3.
    #define EMS_TYPE_RC35StatusMessage_curr 3 // current temp
    EMS_Thermostat.curr_roomTemp = _toFloat(EMS_TYPE_RC35StatusMessage_curr, data);

  • MQTT buffers
    please increase the buffers a bit. Sometimes, the thermostat_data messsage is not complete. 524 bytes works for me

@SpaceTeddy SpaceTeddy added the bug Something isn't working label Jan 3, 2019
@proddy
Copy link
Collaborator

proddy commented Jan 3, 2019

oops, The offset 7 vs 6 is a bug my side. I can't count. Fixed.

What I really need is someone with an official RC35 that can confirm the 0x3E has the current temp at offset 3.

@proddy
Copy link
Collaborator

proddy commented Jan 3, 2019

buffer increased from 500 to 600

@proddy
Copy link
Collaborator

proddy commented Jan 3, 2019

and made your changes in 1.2.4

@SpaceTeddy
Copy link
Contributor Author

please increase also StaticJsonBuffer<512> jsonBuffer;
without increasing this JsonBuffer, the thermostat_data message is not complete

thx and have a good sleep.

@proddy
Copy link
Collaborator

proddy commented Jan 3, 2019

done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants