Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten Package Issue #1246

Closed
zachcp opened this issue Jul 30, 2024 · 10 comments
Closed

Emscripten Package Issue #1246

zachcp opened this issue Jul 30, 2024 · 10 comments

Comments

@zachcp
Copy link

zachcp commented Jul 30, 2024

I was following the instructions' on @wolfv 's great post and hit the following issue:

pixi run build-emscripten-wasm32-pkg  ./recipes/recipes_emscripten/qhull
# Cannot solve the request because of: No candidates were found for emscripten_emscripten-wasm32 3.1.45.*.

image

image

@zachcp
Copy link
Author

zachcp commented Jul 30, 2024

Looks like theres a pixi init that is needed.

@zachcp
Copy link
Author

zachcp commented Jul 30, 2024

Confirming that once pixi init is done, I can build ( or at least the build is in progress )

@zachcp zachcp closed this as completed Jul 30, 2024
@zachcp zachcp reopened this Jul 30, 2024
@zachcp
Copy link
Author

zachcp commented Jul 30, 2024

  • Same error.
  • Also cannot build the example package, regex
# https://emscripten-forge.org/development/local_builds/
# this only needs to be done once
pixi run setup

# this builds the package
pixi run build-emscripten-wasm32-pkg recipes/recipes_emscripten/regex

@zachcp
Copy link
Author

zachcp commented Jul 30, 2024

looks like the emscripten version is newer than the output. Seems that updating this version in the conda_build_config.yaml yields progress. Updating that allows the builds to proceed.

c_compiler_version:
  - if: emscripten
    then:
      - 3.1.58    // <---- was 3.1.45

@zachcp
Copy link
Author

zachcp commented Jul 30, 2024

Aaaaand built! Great!

@zachcp
Copy link
Author

zachcp commented Jul 30, 2024

Looks like emscripten is in the processs of being upgraded. Just bad timing on my part.

@zachcp zachcp closed this as completed Jul 30, 2024
@DerThorsten
Copy link
Contributor

@zachcp actually the update to emscripten 3.1.58 should not yet be visible to users.
There was a tiny problem that the local builds of the compiler package where already using 3.1.58 (the version in the recipe was already the new one, I change the version in the recipe back to 3.1.45, now local builds should work as expected)

@DerThorsten DerThorsten reopened this Jul 31, 2024
@DerThorsten
Copy link
Contributor

@wolfv we could prevent these issues by also uploading the compiler packages for osx-arm64.

@wolfv
Copy link
Contributor

wolfv commented Jul 31, 2024

Yes, it should be quite straightforward to build them in CI (especially since Github actions has the osx-arm64 runners these days).

@DerThorsten
Copy link
Contributor

Yes, it should be quite straightforward to build them in CI (especially since Github actions has the osx-arm64 runners these days)

we should run this workflow also for mac https://github.com/emscripten-forge/recipes/blob/main/.github/workflows/build_recipes.yaml but only build the packages from the 'recipes/recipes' dir (and not 'recipes/recipes_emscrtipten' dir)
and then only upload the packages if they are for osx-arm64 (there are also noarch pkgs in recipes/recipess)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants