Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support package_root_url from empack package data #69

Closed

Conversation

trungleduc
Copy link
Contributor

Reference

Closes #68

Code changes

pyjs will use the package root URL defined in the package data generated by empack to construct the download URL. If this root URL is not defined, it will fall back to the default package_tarballs_root_url as usual.

Backwards-incompatible changes

N/A

@trungleduc
Copy link
Contributor Author

cc @DerThorsten @martinRenou

@martinRenou martinRenou requested a review from DerThorsten June 13, 2024 15:13
@DerThorsten
Copy link
Collaborator

lets call this optional extra field in in the package not package_root_url but just url and use this directly as the URL if present. Ie instead of concatenating the package_root_url with pkg.filename we directly use url if url is existing in the pkg object

@trungleduc
Copy link
Contributor Author

lets call this optional extra field in in the package not package_root_url but just url and use this directly as the URL if present. Ie instead of concatenating the package_root_url with pkg.filename we directly use url if url is existing in the pkg object

I agree, will update the PR. On a side note, does the file extension matter? Or I can save my packages to other file extensions than tar.gz?

@DerThorsten
Copy link
Collaborator

tar.gz

Do you just want to have a different ending or do you actually want to use a different compression format?
Atm is has to be a gzip'ed tarball.
The actual ending of the file should not matter that much

@trungleduc
Copy link
Contributor Author

Just ending. I learned with a client that their proxy blocks downloading tar.gz file but not others. They can use this URL config to trick their proxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing python package URLs to the bootstrap_python function
2 participants