-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering: Include everything by default #98
Filtering: Include everything by default #98
Conversation
@DerThorsten Would you like to have a look? It's unclear to me why the CI fails, it looks like there is a timeout error on the playwright tests |
I'm reworking the implementation to completely ditch the |
So we do no filtering by default, and you can just specify what to remove, and that's it? |
Yep, that was what I implemented initially but I've done it in the default config. I just reworked the implementation to do this in the Python code. That way if users are already shipping their own config they will get the fix too. |
I should be able to debug this, I'm looking at the diff between the packed env on |
ff2c419
to
3a3b209
Compare
The CI failure should be fixed by emscripten-forge/pyjs#67 |
f481aaf
to
9ccc0d7
Compare
Co-authored-by: Thorsten Beier <[email protected]>
9ccc0d7
to
bd5a4a8
Compare
Towards fixing jupyterlite/xeus#66
This PR updates the empack config to include everything by default, and only extra exclude rules should be added for packages.
I believe the original filtering implementation is good, it's our usage of the config that was not user-friendly nor practical.