Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTP login bug #206

Closed
adampweb opened this issue Dec 28, 2017 · 2 comments
Closed

TOTP login bug #206

adampweb opened this issue Dec 28, 2017 · 2 comments
Labels
Milestone

Comments

@adampweb
Copy link

I found a bug in the next file: application/libraries/Aauth.php
line 188 and 189:
with bug (this bug is prevent the totp-verification):
if($this->config_vars['totp_active'] == TRUE AND $this->config_vars['totp_only_on_ip_change'] == FALSE AND $this->config_vars['totp_two_step_login_active'] == FALSE){
if($this->config_vars['totp_two_step_login_active'] == TRUE){

I corrected it and that working correctly:
188 and 189 line:
if($this->config_vars['totp_active'] == TRUE AND $this->config_vars['totp_only_on_ip_change'] == FALSE AND $this->config_vars['totp_two_step_login_active'] == TRUE){
if($this->config_vars['totp_two_step_login_active'] == TRUE){

@REJack
Copy link
Collaborator

REJack commented Dec 30, 2017

Thanks for reporting the bug, I'll fix this later.

@REJack REJack added the bug label Dec 30, 2017
@REJack REJack added this to the v2.5.14 milestone Feb 25, 2018
REJack added a commit that referenced this issue Feb 28, 2018
@REJack
Copy link
Collaborator

REJack commented Feb 28, 2018

I've fixed it in the master branch, you can test it 😄

@REJack REJack closed this as completed Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants