-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(desktop): support install mqttx cli one click #1712
Conversation
@ysfscream I see that the https://github.com/jorangreef/sudo-prompt project has been archived. Is there a more suitable library that is still being maintained? |
@ysfscream I noticed that it needs to be done manually on Windows, but it can be achieved by configuring system environment variables. You can refer to https://stackoverflow.com/questions/59560042/how-to-append-values-to-the-path-environment-variable-in-nodejs. |
I am still looking for a suitable replacement. Although the current project has been archived, it is still functional and stable, with 2 million weekly downloads on NPM. Please let me know if you have a suitable alternative in mind. |
Thank you for the suggestion! This looks very useful. I'll try implementing this in the next PR. |
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
The desktop version and the CLI version installations are relatively independent, and users need to download them separately in different scenarios.
Issue Number
Example: None
What is the new behavior?
After downloading the desktop version, allow users to directly install MQTTX CLI with one click if needed.
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information