Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new JSX entry points for the automatic runtime #1970
Added new JSX entry points for the automatic runtime #1970
Changes from 7 commits
d1c9bc6
4967f9c
6eeb60a
8d3d88e
23c7074
0750e8f
bcd6918
338a0e8
5dec9f1
09b5a55
5b3250f
82b44ba
c471b94
17680e7
70f0969
6181943
45b28c3
faac259
5159b99
ed682ee
a1cc40b
341b5a6
733b6f7
23e68d3
386b855
2798e54
ad892cb
8f6271e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's weird that these are named
core
, yeah? I tried to make itjsx-runtime
but preconstruct overrode it. In any case, it works. We have:@emotion/core/dist/core.esm.js
@emotion/core/jsx-runtime/dist/core.esm.js
and so on. The imports seem to work in the
minimal-react
so 🤷♀️ maybe it doesn't matter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it doesnt matter - i agree the naming convention used for those files is confusing, we have already agreed in the past on making that change but I'm not sure when it will land