Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifier name is missing from the class name #370

Closed
smashercosmo opened this issue Oct 2, 2017 · 4 comments
Closed

Identifier name is missing from the class name #370

smashercosmo opened this issue Oct 2, 2017 · 4 comments

Comments

@smashercosmo
Copy link

Just wanted to ask if this feature (#253) was removed at some point? And if yes what was the reason behind it? Because currently I see just 'css-hash'-like names in the resulting markup.

  • emotion version: 8.0.2-12
  • react version: 16.0.0
@emmatown
Copy link
Member

emmatown commented Oct 2, 2017

It was removed because it was a side-effect of component selectors which were removed (#334) but we added source maps which can be much more powerful.

@smashercosmo
Copy link
Author

smashercosmo commented Oct 2, 2017

Yeah, source maps are awesome, but it's really hard to inspect markup in devtools, because you can 't vissually distinguish one tag from another.

@emmatown
Copy link
Member

emmatown commented Nov 8, 2017

Closed via #375 and #442

Use the autoLabel option in your config for babel-plugin-emotion and the identifier name will be on the class name.

@emmatown emmatown closed this as completed Nov 8, 2017
@smashercosmo
Copy link
Author

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants