Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what the packages #1512

Closed
geddski opened this issue Sep 19, 2019 · 3 comments
Closed

what the packages #1512

geddski opened this issue Sep 19, 2019 · 3 comments

Comments

@geddski
Copy link

geddski commented Sep 19, 2019

I dig emotion once it's all setup, but I'm straight up confused by the packages. I have three projects using emotion 9, via the emotion-react package.

I'm trying to upgrade them to the latest emotion and have no fetching idea which package(s) to use now.

image

This is a mess y'all. I use css, injectGlobal, cx, and sometimes styled.div. Gotta admit I'm lost with where everything went now and how to upgrade.

@geddski
Copy link
Author

geddski commented Sep 19, 2019

the docs appear to be just as confused as I am

image

@Andarist
Copy link
Member

The linked docs are correct - that's because css from @emotion/core and css from emotion are 2 different functions with slightly different behaviors. The one from emotion returns a usable class name string while the one from @emotion/core returns an opaque object describing the class name.

@Andarist
Copy link
Member

RFC has just been opened #1635 with some proposed name changes, I'm going to close this issue, but we are very keen to hear what you think of the proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants