Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempting to serialize an empty xmlobject results in a non-obvious error message #7

Closed
rlskoeser opened this issue Jan 28, 2013 · 1 comment
Closed

attempting to serialize an empty xmlobject results in a non-obvious error message #7

rlskoeser opened this issue Jan 28, 2013 · 1 comment
Assignees
@rlskoeser

Comments

@rlskoeser
Copy link
Contributor

No description provided.

@ghost ghost assigned rlskoeser Jan 28, 2013
@rlskoeser
Copy link
Contributor Author

I think this was only happening because of the error in #6, because normally it should not be possible to initialize an XmlObject instance that doesn't actually have a node.

I don't think it makes sense to add a check in the serialize method, because if we have to check there we'd have to start checking pretty much everywhere, and we ought to be able to assume class internals are sane. Really, we just need to prevent this from happening if we find anything besides the xsl_transform that could generate an XmlObject in this bizarre state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlskoeser rlskoeser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rlskoeser