Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add more try/catch around zip files #994

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 8, 2024

RE: #991

@emmercm emmercm self-assigned this Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/zip-try-catch" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review March 8, 2024 05:43
@emmercm emmercm enabled auto-merge (squash) March 8, 2024 05:44
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.36%. Comparing base (176d7ef) to head (552320f).

Files Patch % Lines
src/types/files/archives/zip.ts 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
- Coverage   93.38%   93.36%   -0.03%     
==========================================
  Files          89       89              
  Lines        5594     5605      +11     
  Branches     1311     1314       +3     
==========================================
+ Hits         5224     5233       +9     
- Misses        352      354       +2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 6d86a9f into main Mar 8, 2024
57 checks passed
@emmercm emmercm deleted the emmercm/zip-try-catch branch March 8, 2024 05:49
Copy link

github-actions bot commented Apr 8, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant