Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: IndexedFiles class #992

Merged
merged 9 commits into from
Mar 9, 2024
Merged

Refactor: IndexedFiles class #992

merged 9 commits into from
Mar 9, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 8, 2024

RE: #818

@emmercm emmercm self-assigned this Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/indexed-files" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm changed the base branch from main to emmercm/romprops-extends-checksumprops March 8, 2024 02:41
Base automatically changed from emmercm/romprops-extends-checksumprops to main March 8, 2024 03:05
@emmercm emmercm changed the title Refactor: IndexedFiles struct Refactor: IndexedFiles class Mar 8, 2024
@emmercm emmercm marked this pull request as ready for review March 9, 2024 03:10
@emmercm emmercm enabled auto-merge (squash) March 9, 2024 03:10
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 93.40%. Comparing base (8cbd9fc) to head (fce25ea).

Files Patch % Lines
src/modules/romIndexer.ts 93.33% 3 Missing ⚠️
src/types/indexedFiles.ts 98.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   93.36%   93.40%   +0.04%     
==========================================
  Files          89       90       +1     
  Lines        5605     5656      +51     
  Branches     1314     1327      +13     
==========================================
+ Hits         5233     5283      +50     
- Misses        354      355       +1     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit a1acfd3 into main Mar 9, 2024
52 of 53 checks passed
@emmercm emmercm deleted the emmercm/indexed-files branch March 9, 2024 03:18
Copy link

github-actions bot commented Apr 9, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant