Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: prefer-game-regex, prefer-rom-regex options #918

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Feb 9, 2024

Fixes: #754

@emmercm emmercm self-assigned this Feb 9, 2024
@emmercm emmercm enabled auto-merge (squash) February 9, 2024 02:00
@emmercm emmercm disabled auto-merge February 9, 2024 02:01
Copy link

github-actions bot commented Feb 9, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/prefer-regex" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm changed the title Feature: prefer-regex option Feature: prefer-game-regex, prefer-rom-regex options Feb 9, 2024
@github-actions github-actions bot changed the title Feature: prefer-game-regex, prefer-rom-regex options Feature: prefer-regex option Feb 9, 2024
@emmercm emmercm enabled auto-merge (squash) February 9, 2024 02:33
@emmercm emmercm disabled auto-merge February 9, 2024 02:44
@emmercm emmercm changed the title Feature: prefer-regex option Feature: prefer-game-regex, prefer-rom-regex options Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3a18ab) 93.39% compared to head (512ab81) 93.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
+ Coverage   93.39%   93.42%   +0.02%     
==========================================
  Files          88       88              
  Lines        5408     5431      +23     
  Branches     1234     1246      +12     
==========================================
+ Hits         5051     5074      +23     
  Misses        339      339              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm enabled auto-merge (squash) February 9, 2024 02:45
@emmercm emmercm merged commit 11bfacb into main Feb 9, 2024
52 of 53 checks passed
@emmercm emmercm deleted the emmercm/prefer-regex branch February 9, 2024 02:46
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling TOSEC alternates and duplicates across different rom types
1 participant