Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle stream errors when reading a zip file #875

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jan 4, 2024

Fixes #853

@emmercm emmercm self-assigned this Jan 4, 2024
@emmercm emmercm enabled auto-merge (squash) January 4, 2024 01:26
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (89ae8c1) 93.45% compared to head (7f0294d) 93.43%.

Files Patch % Lines
src/types/files/archives/zip.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   93.45%   93.43%   -0.02%     
==========================================
  Files          86       86              
  Lines        5300     5301       +1     
  Branches     1215     1215              
==========================================
  Hits         4953     4953              
- Misses        329      330       +1     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 4, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/ignore-zip-stream-errors" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit 983c085 into main Jan 4, 2024
53 checks passed
@emmercm emmercm deleted the emmercm/ignore-zip-stream-errors branch January 4, 2024 01:31
Copy link

github-actions bot commented Feb 3, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Igir fails on corrupted Zip files
1 participant