Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dir-letter-count option #849

Merged
merged 10 commits into from
Feb 1, 2024
Merged

Feature: dir-letter-count option #849

merged 10 commits into from
Feb 1, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Dec 7, 2023

RE: #837

@emmercm emmercm self-assigned this Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dir-letter-count" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review January 31, 2024 05:25
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (168bbde) 93.39% compared to head (69f0713) 93.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #849   +/-   ##
=======================================
  Coverage   93.39%   93.40%           
=======================================
  Files          86       86           
  Lines        5298     5306    +8     
  Branches     1216     1218    +2     
=======================================
+ Hits         4948     4956    +8     
  Misses        332      332           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 5575d20 into main Feb 1, 2024
52 checks passed
@emmercm emmercm deleted the emmercm/dir-letter-count branch February 1, 2024 00:18
Copy link

github-actions bot commented Mar 2, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants