Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace robloach-datfile with a custom CMPro DAT parser #784

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 23, 2023

RE: #781

@emmercm emmercm self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #784 (585338a) into main (bb6cade) will decrease coverage by 0.07%.
The diff coverage is 89.10%.

@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   93.71%   93.64%   -0.07%     
==========================================
  Files          83       84       +1     
  Lines        5041     5131      +90     
  Branches     1137     1163      +26     
==========================================
+ Hits         4724     4805      +81     
- Misses        300      309       +9     
  Partials       17       17              
Files Coverage Δ
src/modules/datScanner.ts 87.26% <88.00%> (+0.39%) ⬆️
src/types/dats/cmpro/cmProParser.ts 89.47% <89.47%> (ø)

@github-actions
Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/cmpro-parser" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit d8ef643 into main Oct 23, 2023
52 of 53 checks passed
@emmercm emmercm deleted the emmercm/cmpro-parser branch October 23, 2023 01:53
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant