Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: prefer input files not from the output path #767

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 16, 2023

No description provided.

@emmercm emmercm self-assigned this Oct 16, 2023
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/prefer-same-disk" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm changed the title Feature: prefer input files on the output disk Feature: prefer input files not from the output path Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #767 (c17988d) into main (bdecb10) will decrease coverage by 0.01%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   93.50%   93.50%   -0.01%     
==========================================
  Files          85       85              
  Lines        5189     5200      +11     
  Branches     1177     1183       +6     
==========================================
+ Hits         4852     4862      +10     
- Misses        319      320       +1     
  Partials       18       18              
Files Coverage Δ
src/polyfill/fsPoly.ts 85.63% <100.00%> (+0.25%) ⬆️
src/modules/fileIndexer.ts 94.64% <90.90%> (-1.20%) ⬇️

@emmercm emmercm marked this pull request as ready for review October 29, 2023 00:28
@emmercm emmercm merged commit 7682a97 into main Oct 29, 2023
53 of 54 checks passed
@emmercm emmercm deleted the emmercm/prefer-same-disk branch October 29, 2023 00:28
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant