Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: progress bar symbols update #1294

Merged
merged 19 commits into from
Aug 24, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 21, 2024

No description provided.

@emmercm emmercm self-assigned this Aug 21, 2024
@emmercm emmercm enabled auto-merge (squash) August 21, 2024 02:23
@emmercm emmercm disabled auto-merge August 21, 2024 03:36
@emmercm emmercm marked this pull request as draft August 21, 2024 04:09
@emmercm emmercm marked this pull request as ready for review August 24, 2024 01:17
@emmercm emmercm enabled auto-merge (squash) August 24, 2024 01:17
@emmercm emmercm merged commit 3ee18bd into emmercm/3.0.0-feature Aug 24, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/20240820-progress-symbols branch August 24, 2024 01:24
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.89%. Comparing base (dcafd6c) to head (f7afdcd).
Report is 1 commits behind head on emmercm/3.0.0-feature.

Files Patch % Lines
src/console/progressBarCli.ts 83.33% 1 Missing ⚠️
src/modules/directoryCleaner.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1294      +/-   ##
=========================================================
- Coverage                  92.90%   92.89%   -0.02%     
=========================================================
  Files                        117      117              
  Lines                       7428     7441      +13     
  Branches                    1801     1806       +5     
=========================================================
+ Hits                        6901     6912      +11     
- Misses                       505      528      +23     
+ Partials                      22        1      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant