Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: downloading & extracting temp files #1278

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 12, 2024

Fixes: #1275

@emmercm emmercm self-assigned this Aug 12, 2024
@emmercm emmercm changed the title Fix: create temp dir before extracting to temp file Fix: downloading & extracting temp files Aug 13, 2024
@emmercm emmercm enabled auto-merge (squash) August 13, 2024 00:18
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.64%. Comparing base (fecdffd) to head (8d3593a).

Files Patch % Lines
src/types/files/file.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1278      +/-   ##
=========================================================
- Coverage                  92.73%   92.64%   -0.10%     
=========================================================
  Files                        117      117              
  Lines                       7325     7338      +13     
  Branches                    1768     1774       +6     
=========================================================
+ Hits                        6793     6798       +5     
- Misses                       531      539       +8     
  Partials                       1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit afd30f6 into emmercm/3.0.0-feature Aug 13, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/create-archive-temp-dir branch August 13, 2024 00:52
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant