Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: progress bar size & fixes #1270

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 3, 2024

No description provided.

@emmercm emmercm self-assigned this Aug 3, 2024
@emmercm emmercm enabled auto-merge (squash) August 3, 2024 05:30
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 20 lines in your changes missing coverage. Please review.

Project coverage is 93.22%. Comparing base (e786f65) to head (57588d5).

Files Patch % Lines
src/console/progressBarCli.ts 20.00% 12 Missing ⚠️
src/polyfill/timePoly.ts 0.00% 6 Missing ⚠️
src/console/singleBarFormatted.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1270      +/-   ##
=========================================================
- Coverage                  93.29%   93.22%   -0.07%     
=========================================================
  Files                        116      117       +1     
  Lines                       7219     7236      +17     
  Branches                    1596     1601       +5     
=========================================================
+ Hits                        6735     6746      +11     
- Misses                       483      489       +6     
  Partials                       1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 667173d into emmercm/3.0.0-feature Aug 7, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/3.0-progress-bar branch August 7, 2024 22:37
Copy link

github-actions bot commented Aug 7, 2024

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

github-actions bot commented Sep 7, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant