Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: group bin/cue files together when inferring games #1239

Merged
merged 99 commits into from
Jul 27, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 26, 2024

No description provided.

@emmercm emmercm self-assigned this Jul 26, 2024
Base automatically changed from emmercm/chd to emmercm/3.0.0-feature July 26, 2024 01:38
@emmercm emmercm marked this pull request as ready for review July 26, 2024 23:31
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 95.94595% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.18%. Comparing base (d82e293) to head (caeb5bb).

Files Patch % Lines
src/modules/datGameInferrer.ts 96.96% 2 Missing ⚠️
src/modules/candidateGenerator.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1239      +/-   ##
=========================================================
- Coverage                  93.36%   93.18%   -0.18%     
=========================================================
  Files                        112      112              
  Lines                       7022     7063      +41     
  Branches                    1548     1552       +4     
=========================================================
+ Hits                        6556     6582      +26     
- Misses                       465      480      +15     
  Partials                       1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm enabled auto-merge (squash) July 27, 2024 00:13
@emmercm emmercm merged commit 6535f5b into emmercm/3.0.0-feature Jul 27, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/group-bin-cue-infer branch July 27, 2024 00:13
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant