Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: scanning support for NKit ISOs #1226

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 20, 2024

RE: #937

@emmercm emmercm self-assigned this Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5d738ef). Learn more about missing BASE report.

Files Patch % Lines
src/types/files/archives/nkitIso.ts 87.50% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1226   +/-   ##
=======================================
  Coverage        ?   93.23%           
=======================================
  Files           ?      109           
  Lines           ?     6713           
  Branches        ?     1590           
=======================================
  Hits            ?     6259           
  Misses          ?      453           
  Partials        ?        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm changed the base branch from main to emmercm/3.0.0-feature July 22, 2024 05:31
@emmercm emmercm marked this pull request as ready for review July 22, 2024 05:32
@emmercm emmercm merged commit 6d65525 into emmercm/3.0.0-feature Jul 22, 2024
9 checks passed
@emmercm emmercm deleted the emmercm/nkit branch July 22, 2024 05:32
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant