Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache more stuff #1234

Closed
dch82 opened this issue Jul 23, 2024 · 4 comments · Fixed by #1238
Closed

Cache more stuff #1234

dch82 opened this issue Jul 23, 2024 · 4 comments · Fixed by #1238
Assignees
Labels
enhancement New feature or request

Comments

@dch82
Copy link

dch82 commented Jul 23, 2024

Is your feature request related to a problem?

I think it would speed things up a lot more if stuff like header detection and DAT detection was cached because right now a lot of these high quantity operations take a lot of time.

Describe the solution you'd like

To cache results of operations so they take less time after the first run.

Additional context

No response

@dch82 dch82 added the enhancement New feature or request label Jul 23, 2024
@emmercm
Copy link
Owner

emmercm commented Jul 23, 2024

I fully agree on header detection, it's something I've been thinking about recently. The recent extension correction features fall into this same bucket as well. And I think it will be even more important as I'm adding support for compressed disc images such as CHD and NKit.

Can you elaborate more on the "DAT detection" piece?

@dch82
Copy link
Author

dch82 commented Jul 24, 2024

Like when IGIR reads the files and makes sure they are valid dats

@emmercm
Copy link
Owner

emmercm commented Jul 24, 2024

Scanning for + parsing the contents of DATs is generally fast unless processing an exceptionally large archive such as TOSEC's. Loading it from a cache file would take roughly the same amount of time, except it would greatly increase the cache file's size.

I'll look to focus on the other features soon.

Copy link

🔒 Inactive issue lock

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants