Refactor: ban Array#push() (#792)

.eslintrc

@@ -110,6 +110,10 @@
     "unicorn/empty-brace-spaces": "error",
 
     // ***** Arrays *****
+    "no-restricted-syntax": ["error", {
+      "selector": "CallExpression[callee.property.name='push'] > SpreadElement",
+      "message": "Array#push(...Array) can cause 'call stack size exceeded' runtime errors when pushing many values, prefer 'Array = [...Array, ...Array]'"
+    }],
     "unicorn/no-new-array": "error",
     // TypeScript doesn't do a good job of reporting indexed values as potentially undefined, such as `[1,2,3][999]`
     "unicorn/prefer-at": "error",
@@ -144,7 +148,6 @@
     // ***** airbnb-base, airbnb-typescript/base *****
     "no-await-in-loop": "off",
     "no-bitwise": "off",
-    "no-restricted-syntax": "off",
 
     // ***** plugin:jest/recommended *****
     // A lot of test files define their own expect functions

src/igir.ts

@@ -79,8 +79,8 @@ export default class Igir {
     }
 
     const datsToWrittenFiles = new Map<DAT, File[]>();
-    const romOutputDirs: string[] = [];
-    const movedRomsToDelete: File[] = [];
+    let romOutputDirs: string[] = [];
+    let movedRomsToDelete: File[] = [];
     const datsStatuses: DATStatus[] = [];
 
     // Process every DAT
@@ -106,12 +106,15 @@ export default class Igir {
         indexedRoms,
         patches,
       );
-      romOutputDirs.push(...this.getCandidateOutputDirs(filteredDat, parentsToCandidates));
+      romOutputDirs = [
+        ...romOutputDirs,
+        ...this.getCandidateOutputDirs(filteredDat, parentsToCandidates),
+      ];
 
       // Write the output files
       const movedRoms = await new CandidateWriter(this.options, progressBar)
         .write(filteredDat, parentsToCandidates);
-      movedRomsToDelete.push(...movedRoms);
+      movedRomsToDelete = [...movedRomsToDelete, ...movedRoms];
       const writtenRoms = [...parentsToCandidates.values()]
         .flat()
         .flatMap((releaseCandidate) => releaseCandidate

src/modules/candidatePatchGenerator.ts

@@ -80,7 +80,7 @@ export default class CandidatePatchGenerator extends Module {
         //  ReleaseCandidate for each Game, so remember which Games we've seen for this Parent
         const seenGames = new Set<Game>();
 
-        const parentsAndReleaseCandidates: [Parent, ReleaseCandidate[]][] = [
+        let parentsAndReleaseCandidates: [Parent, ReleaseCandidate[]][] = [
           [parent, releaseCandidates],
         ];
 
@@ -99,7 +99,7 @@ export default class CandidatePatchGenerator extends Module {
           seenGames.add(releaseCandidate.getGame());
 
           if (patchedParents) {
-            parentsAndReleaseCandidates.push(...patchedParents);
+            parentsAndReleaseCandidates = [...parentsAndReleaseCandidates, ...patchedParents];
           }
         }
 

src/modules/directoryCleaner.ts

@@ -119,10 +119,8 @@ export default class DirectoryCleaner extends Module {
     }
 
     // Otherwise, recurse and look for empty subdirectories
-    const emptyDirs: string[] = [];
-    await Promise.all(subDirs.map(async (subDir) => {
-      emptyDirs.push(...await this.getEmptyDirs(subDir));
-    }));
-    return emptyDirs;
+    return (await Promise.all(
+      subDirs.map(async (subDir) => this.getEmptyDirs(subDir)),
+    )).flat();
   }
 }

src/polyfill/fsPoly.ts

@@ -296,7 +296,7 @@ export default class FsPoly {
   }
 
   static async walk(pathLike: PathLike, callback?: FsWalkCallback): Promise<string[]> {
-    const output = [];
+    let output: string[] = [];
 
     let files: string[];
     try {
@@ -314,12 +314,12 @@ export default class FsPoly {
       const fullPath = path.join(pathLike.toString(), file);
       if (await this.isDirectory(fullPath)) {
         const subDirFiles = await this.walk(fullPath);
-        output.push(...subDirFiles);
+        output = [...output, ...subDirFiles];
         if (callback) {
           callback(subDirFiles.length - 1);
         }
       } else {
-        output.push(fullPath);
+        output = [...output, fullPath];
       }
     }