Add web support for zoom_factor
#4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the library! I did my first bigger project in rust and am really happy with it, especially the ease with which one can create both a native and web application. My prof had some difficulty reading the text, and I can see how one might have problems, especially with the moderate text contrast in dark mode. So I created this PR because I would like to enlarge the website a bit by default |
|
The intent of the current behavior is that the web browser is in charge of the zoom-factor/pixels-per-point. If you launch a native egui app and press cmd-plus, you will zoom in, because egui catches that command and adjust the zoom factor. Do you want to be able to zoom an egui app independently of the browsers setting? |
|
Exactly, I don't want to override the browsers zoom level, but I would like to be able to adjust the zoom level of the application programmatically |
emilk
approved these changes
Mar 29, 2024
emilk
added
web
|
Makes sense - thanks for the PR! |
emilk
added a commit
that referenced
this pull request
Mar 29, 2024
Before, when setting the `zoom_factor`, the website was already enlarged, but the zoom was ignored when calculating the logical window size and mouse position, causing an offset between the actual cursor and selected elements. That is addressed here --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
Merged
emilk
added a commit
that referenced
this pull request
Mar 29, 2024
## egui changelog ### 🐛 Fixed * Fix visual glitch on the right side of highly rounded rectangles [#4244](#4244) * Prevent visual glitch when shadow blur width is very high [#4245](#4245) * Fix `InputState::any_touches` and add `InputState::has_touch_screen` [#4247](#4247) * Fix `Context::repaint_causes` returning no causes [#4248](#4248) * Fix touch-and-hold to open context menu [#4249](#4249) * Hide shortcut text on zoom buttons if `zoom_with_keyboard` is false [#4262](#4262) ### 🔧 Changed * Don't apply a clip rect to the contents of an `Area` or `Window` [#4258](#4258) ## eframe changelog * Web: repaint if the `#hash` in the URL changes [#4261](#4261) * Add web support for `zoom_factor` [#4260](#4260) (thanks [@justusdieckmann](https://github.com/justusdieckmann)!) --------- Co-authored-by: Justus Dieckmann <[email protected]>
emilk
added a commit
to emilk/egui_plot
that referenced
this pull request
Jul 15, 2024
## egui changelog ### 🐛 Fixed * Fix visual glitch on the right side of highly rounded rectangles [#4244](emilk/egui#4244) * Prevent visual glitch when shadow blur width is very high [#4245](emilk/egui#4245) * Fix `InputState::any_touches` and add `InputState::has_touch_screen` [#4247](emilk/egui#4247) * Fix `Context::repaint_causes` returning no causes [#4248](emilk/egui#4248) * Fix touch-and-hold to open context menu [#4249](emilk/egui#4249) * Hide shortcut text on zoom buttons if `zoom_with_keyboard` is false [#4262](emilk/egui#4262) ### 🔧 Changed * Don't apply a clip rect to the contents of an `Area` or `Window` [#4258](emilk/egui#4258) ## eframe changelog * Web: repaint if the `#hash` in the URL changes [#4261](emilk/egui#4261) * Add web support for `zoom_factor` [#4260](emilk/egui#4260) (thanks [@justusdieckmann](https://github.com/justusdieckmann)!) --------- Co-authored-by: Justus Dieckmann <[email protected]>
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Before, when setting the `zoom_factor`, the website was already enlarged, but the zoom was ignored when calculating the logical window size and mouse position, causing an offset between the actual cursor and selected elements. That is addressed here --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
## egui changelog ### 🐛 Fixed * Fix visual glitch on the right side of highly rounded rectangles [emilk#4244](emilk#4244) * Prevent visual glitch when shadow blur width is very high [emilk#4245](emilk#4245) * Fix `InputState::any_touches` and add `InputState::has_touch_screen` [emilk#4247](emilk#4247) * Fix `Context::repaint_causes` returning no causes [emilk#4248](emilk#4248) * Fix touch-and-hold to open context menu [emilk#4249](emilk#4249) * Hide shortcut text on zoom buttons if `zoom_with_keyboard` is false [emilk#4262](emilk#4262) ### 🔧 Changed * Don't apply a clip rect to the contents of an `Area` or `Window` [emilk#4258](emilk#4258) ## eframe changelog * Web: repaint if the `#hash` in the URL changes [emilk#4261](emilk#4261) * Add web support for `zoom_factor` [emilk#4260](emilk#4260) (thanks [@justusdieckmann](https://github.com/justusdieckmann)!) --------- Co-authored-by: Justus Dieckmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when setting the
zoom_factor, the website was already enlarged, but the zoom was ignored when calculating the logical window size and mouse position, causing an offset between the actual cursor and selected elements. That is addressed here