(rustbasic) In Progress : Testing... #4182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbasic
changed the title
emilk
requested changes
Mar 21, 2024
Comment on lines
289
to
294
|
|
||
| let viewport_id = egui_ctx.viewport_id(); | ||
| // TODO : Do not recall until the next repaint. | ||
| // 1000 millis / 60 fps = 16.67 millis | ||
| self.egui_ctx | ||
| .request_repaint_after_for(std::time::Duration::from_millis(8), viewport_id); |
There was a problem hiding this comment.
this will just cause a hot repaint loop
Suggested change
| let viewport_id = egui_ctx.viewport_id(); | |
| // TODO : Do not recall until the next repaint. | |
| // 1000 millis / 60 fps = 16.67 millis | |
| self.egui_ctx | |
| .request_repaint_after_for(std::time::Duration::from_millis(8), viewport_id); |
| ) | ||
| } | ||
| } else { | ||
| let visuals = &ui.style().visuals.widgets.inactive; | ||
| epaint::RectShape::stroke( | ||
| frame_rect, | ||
| visuals.rounding, | ||
| visuals.bg_stroke, // TODO(emilk): we want to show something here, or a text-edit field doesn't "pop". | ||
| ui.visuals().widgets.unhovered.bg_stroke, // TODO(emilk): we want to show something here, or a text-edit field doesn't "pop". |
crates/egui-winit/src/lib.rs
Outdated
Comment on lines
949
to
958
| /* | ||
| // Deprecated | ||
| if cfg!(target_os = "windows") { | ||
| // It's tempting to do this, but it leads to a deadlock on Mac when running | ||
| // `cargo run -p custom_window_frame`. | ||
| // See https://github.com/emilk/egui/issues/3494 | ||
| viewport_info.maximized = Some(window.is_maximized()); | ||
| viewport_info.minimized = Some(window.is_minimized().unwrap_or(false)); | ||
| viewport_info.maximized = Some(window.is_maximized()); | ||
| } | ||
| */ |
crates/egui-winit/src/lib.rs
Outdated
|
|
||
| update_info.minimized = match cfg!(target_os = "windows") { | ||
| true => Some(window.is_minimized().unwrap_or(false)), | ||
| false => window.is_minimized(), |
There was a problem hiding this comment.
As the comment above says, this leads to deadlock on Mac
There was a problem hiding this comment.
As the comment above says, this leads to deadlock on Mac
Okay, I was curious about the results.
Comment on lines
109
to
111
| ViewportExit(WindowId), | ||
|
|
||
| Exit(WindowId), |
crates/eframe/src/native/run.rs
Outdated
| @@ -227,6 +240,7 @@ fn run_and_return( | |||
| }) | |||
| .ok(); | |||
| } | |||
| */ | |||
|
this PR is too big |
rustbasic
changed the title
rustbasic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Progress : Testing...
Don't close, please.
Issues :
fullscreen+transparent+always_on_top#4091eframeon Windows high CPU usage due to excessive calls toglutin::context::make_not_current#4173transparentanddecorationinformation. #4222Pull Requests :
Context::parent_viewport_id_of#4217TextEditexists. #4242IMEevent first #4509This will continue to be updated :
Based on
examples/test_viewportsandexamples/multiple_viewports, all fixed to work properly.wgpuonly testedexamples/test_viewports, so additional testing on your part is needed.