ImageButton ignoring input Image rounding

[v-kat]

ui.add(ImageButton::new(
    egui::Image::new(SizedTexture::new(
        *a_texture_id,
        egui::Vec2::new(1.0, 1.0)
    )).rounding(50.0)
));

https://github.com/emilk/egui/blob/master/crates/egui/src/widgets/button.rs#L620 is the problem line I believe

Expected behavior
The image button should respect the input image's rounding. There should also maybe be an exposed .rounding method on the ImageButton. I might try to fix this later myself....

[chriscate]

@v-kat did you end up working on this? I'm looking for ways to get comfortable with contributing to egui and the code base in general. Thinking this bug may be a nice intro if you didn't already take it on.

[v-kat]

I haven't thanks for asking. You can go ahead with it. I also wanted to check on keyboard support for ImageButton and menu_image_button too. #3288 is an example small PR

[chriscate]

great thanks!

[chriscate]

@v-kat I opened draft PR for this last night (and also added a note/question in there about my current approach). If you get a moment just let me know if there's anything you would change and if not I'll mark it ready for review. I did mention in the PR too that a new rounding() method on the ImageButton itself could be a separate issue/enhancement. Let me know if you disagree though.