Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FINISH tag error when ending from initiator (client) #7

Closed
bcomnes opened this issue Dec 31, 2019 · 3 comments
Closed

FINISH tag error when ending from initiator (client) #7

bcomnes opened this issue Dec 31, 2019 · 3 comments

Comments

@bcomnes
Copy link

bcomnes commented Dec 31, 2019 •
edited
Loading

When you peer.end() from the initiator, the callback resolves without an error, but then the socket and the peer streams from that same peer will emit errors:

Error: Remote closed without sending a FINISH tag (possible MITM vector).

The server/non initiator resolves the session cleanly.

Possibly related to #6? I tried with half open streams on both sides but still getting the same issue. Example here: https://github.com/little-core-labs/secure-rpc-protocol/blob/5a154ae9da52b0bd1058b8df3fb770fba175343c/examples/forward-secret/client.js#L1
@bcomnes
Copy link
Author

bcomnes commented Dec 31, 2019

Also just realizing that the end() callback doesn't ever return an error. I'll clarify this.

@bcomnes
Copy link
Author

bcomnes commented Jan 1, 2020

Putting together a more specific example, bare with me.

@bcomnes
Copy link
Author

bcomnes commented Jan 1, 2020

Closing and remaking a new issue.

@bcomnes bcomnes closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bcomnes