Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Id attribute not unique for table row more actions button #926

Open
weegrom opened this issue Aug 31, 2021 · 0 comments
Open

Id attribute not unique for table row more actions button #926

weegrom opened this issue Aug 31, 2021 · 0 comments

Comments

@weegrom
Copy link
Contributor

weegrom commented Aug 31, 2021

<Button componentId={`${componentId}BtnMoreActions`} theme={theme} componentClass={theme.rowActionButton} disabled={actionInProgress} icon="horizontalDots" onClick={(e: React.FormEvent<HTMLElement>) => this.dropdownToggle(e)} title="More Actions">

@Farhan-emgage can you please look into this. A change made by Roman in c75f2ce results in all more action buttons having the same "BtnMoreActions" id. This creates a potential accessibility issue, as only one of the more actions buttons may be available in assistive technologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant