Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Inhibit portal #297

Open
eternal-sorrow opened this issue Feb 3, 2024 · 5 comments
Open

Implement Inhibit portal #297

eternal-sorrow opened this issue Feb 3, 2024 · 5 comments

Comments

@eternal-sorrow
Copy link

Wlroots supports idle-inhibit protocol, so this should not be too hard.

@columbarius
Copy link
Collaborator

The idle-inhibit protocol requires a wl_surface, which this portal implementation running in the background lacks.

@YellowOnion
Copy link

Anyone know why inhibition stopped working in firefox recently? I don't even know who to blame...mpv seems to work fine, and there's definitely a Portal talking firefox, but who the hell is it, and why does mpv or systemd-inhibit work.

@eternal-sorrow
Copy link
Author

It's probably this bug.

@YellowOnion
Copy link

@eternal-sorrow according to this the "wayland" lock system is also broken: https://bugzilla.mozilla.org/show_bug.cgi?id=1877022, they fixed it, but the closing comment makes me think firefox is expecting sway/wlr to implement the protocol to truly fix it.

It seems like a huge cluster-fuck of 4-5 different protocols, and disagreements on what should be standard, where, systemd tells me to use a specific gnome dbus api...that calls systemd...

My hunch is that xdpw is meant to call systemd inhibit directly to avoid using a wl_surface.

@Consolatis
Copy link

My hunch is that xdpw is meant to call systemd inhibit directly to avoid using a wl_surface.

That won't work for compositors that do not support systemd inhibit (or don't even interact with dbus at all).

Implementing support for the inhibit protocol in xdp-wlr which just translates it into systemd inhibitors is actually way worse than not implementing the interface because then clients like FF will use the interface and do not "fall back" to the wayland native protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants